Skip to content

Add Xiaomi to website supporters - #1056

Merged
karmada-bot merged 1 commit into
karmada-io:mainfrom
zhzhuang-zju:xiaomi
Nov 18, 2026
Merged

karmada-bot merged 1 commit into
karmada-io:mainfrom
zhzhuang-zju:xiaomi

Conversation

@zhzhuang-zju

@zhzhuang-zju zhzhuang-zju commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:
Add Xiaomi to website supporters
Which issue(s) this PR fixes:
Part of karmada-io/community#221

Special notes for your reviewer:
NONE

@karmada-bot karmada-bot added kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. labels Nov 18, 2026
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2026
@zhzhuang-zju zhzhuang-zju changed the title Add Xiaomi to website supporters WIP Add Xiaomi to website supporters Nov 18, 2026
@karmada-bot karmada-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2026
@zhzhuang-zju

Copy link
Copy Markdown
Contributor Author

/remove-kind design

@karmada-bot karmada-bot removed the kind/design Categorizes issue or PR as related to design. label Nov 18, 2026
@zhzhuang-zju zhzhuang-zju changed the title WIP Add Xiaomi to website supporters Add Xiaomi to website supporters Nov 18, 2026
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2026
@zhzhuang-zju

Copy link
Copy Markdown
Contributor Author

@zhzhuang-zju

Copy link
Copy Markdown
Contributor Author

/cc @RainbowMango

Comment thread src/data/supporters.js Outdated
import gmicloud from "../../static/img/supporters/gmicloud.png"
import wellhub from "../../static/img/supporters/wellhub.png"
import qwen from "../../static/img/supporters/qwen.png"
import xiaomi from "!!url-loader!../../static/img/supporters/xiaomi.svg"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhzhuang-zju what's the url-loader thing?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docusaurus imports SVG files as React components, not image URLs, so we need to load Xiaomi’s SVG as a URL using an explicit url-loader import.

Or I can just convert its format to PNG.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chose the second option for consistency.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the Xiaomi supporter-list addition.

No open issues 🎉

What changed in this PR

Adds Xiaomi to the website’s supporter list using the existing data-driven display.

Changes:

  • Adds the Xiaomi SVG logo.
  • Registers Xiaomi’s logo and alternative text in the supporter data.
File Description
static/​img/​supporters/​xiaomi.svg Adds the Xiaomi logo asset.
src/​data/​supporters.js Imports the logo and adds Xiaomi to the supporter list.

Review effort: Max

Signed-off-by: zhzhuang-zju <m17799853869@163.com>
@zhzhuang-zju

Copy link
Copy Markdown
Contributor Author

@RainbowMango RainbowMango left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2026
@karmada-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2026
@karmada-bot
karmada-bot merged commit 0b1cb18 into karmada-io:main Nov 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants